Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connector): remove JsonParser from production code #17016

Merged
merged 2 commits into from
May 31, 2024

Conversation

BugenZhao
Copy link
Member

Signed-off-by: Bugen Zhao i@bugenzhao.comI hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Following up #16996, this PR removes JsonParser from production code. Close #16968.

  • Refactor all unit tests in json_parser.rs to use ByteStreamSourceParserImpl to create a (plain) parser to cover the real path.
  • Move JsonParser to the benchmark of json_vs_plain_parser.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao BugenZhao requested review from stdrc, xiangjinwu and xxchan May 30, 2024 06:29
Copy link
Member Author

BugenZhao commented May 30, 2024

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider rename this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any suggestions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK, json_access_builder? bytes_parser.rs also doesn't have any BytesParser.

@xiangjinwu xiangjinwu requested a review from tabVersion May 30, 2024 06:51
Base automatically changed from bz/parser-bench-use-dispatcher to main May 30, 2024 07:29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems meaningless since we've removed json parser

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still meaningful until we resolve #14815. 🥺

@BugenZhao BugenZhao force-pushed the bz/remove-json-parser branch from bb6d16b to 1f2d16e Compare May 30, 2024 09:26
BugenZhao added 2 commits May 31, 2024 10:16
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao force-pushed the bz/remove-json-parser branch from 1f2d16e to 7aace1c Compare May 31, 2024 02:21
@BugenZhao BugenZhao enabled auto-merge May 31, 2024 02:21
@BugenZhao BugenZhao added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit 9edfd72 May 31, 2024
29 of 30 checks passed
@BugenZhao BugenZhao deleted the bz/remove-json-parser branch May 31, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connector: JsonParser in connector is dead code
4 participants